Repository navigation
fix(provisioning_api): filter users by enabled state on the server - #65468
SebastianKrupinski wants to merge 1 commit into
Conversation
|
/backport to stable35 |
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
|
/compile |
|
I'm honestly not sure this should be fixed in the client. The server builds full details for every disabled user just so we can hide them, and the loop multiplies that. Most of the inline issues also go away without a client-side loop. Maybe we could add an opt-in |
Sure, I was just going for the smallest fix, but the backend fix is better |
ce84c9c to
b0c504e
Compare
b0c504e to
a31e2f8
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
a31e2f8 to
b916a6a
Compare
| $count = 0; | ||
| foreach ($search($limit, $offset) as $user) { | ||
| $count++; | ||
| $offset++; |
There was a problem hiding this comment.
I think this might skip users when there's more than one user backend (e.g. LDAP + Database), since search() pages each backend separately but the offset here counts the merged result. Could you double check?
|
Thank you for the extra effort to improve this by moving it to the server! Just one comment on limit/offset handling on multiple backends...but otherwise looks good :) |
Summary
Resolves: [Bug]: Active Account List Break if 1/3 of Total Accounts are Disabled #47114
Resolves: Client Ticket
The account list in settings fetched pages that included disabled accounts and hid them in the browser. Loading the next page is only triggered when the list footer becomes visible, so when most accounts on a page were disabled the footer never left the viewport and the "Active accounts", group and "Recent accounts" views stopped loading.
Checklist
3. to review, feature component)stable32)AI (if applicable)