Skip to content

fix: move/rename of part file in masked dir/storage - #65506

Open
salmart-dev wants to merge 2 commits into
masterfrom
fix/permission-masks-fixes
Open

salmart-dev wants to merge 2 commits into
masterfrom
fix/permission-masks-fixes

Conversation

@salmart-dev

@salmart-dev salmart-dev commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Resolves: #65505

Follow-up of #62986

  • Allows renaming of .ocTransferId\d+.part files even if they are not uploaded in the same directory as the destination (as this may happen for several reasons)
  • Adds tests for DirPermissionsMask and new cases for the fixed problems
  • Pass missing mtime to touch
  • PermissionsMask checks for CREATE permissions only when target does not exist

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The new behaviour is needed when the partial files are not uploaded
directly at the target directory, which is a configurable option
(part_file_in_storage=false).

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
@salmart-dev salmart-dev self-assigned this Oct 14, 2026
@salmart-dev salmart-dev added the 2. developing Work in progress label Oct 14, 2026
@salmart-dev salmart-dev added this to the Nextcloud 36 milestone Oct 14, 2026
@salmart-dev salmart-dev added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 14, 2026
@salmart-dev
salmart-dev marked this pull request as ready for review October 14, 2026 15:03
@salmart-dev
salmart-dev requested a review from a team as a code owner October 14, 2026 15:03
@salmart-dev
salmart-dev requested review from icewind1991, leftybournes, provokateurin and sorbaugh and removed request for a team October 14, 2026 15:03
@salmart-dev

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@salmart-dev

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@salmart-dev

Copy link
Copy Markdown
Contributor Author

/backport to stable33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: File-request uploads failing with part_file_in_storage = false

1 participant