Repository navigation
Conversation
With --dry-run nothing is changed, but the commands still printed "this can take some time..." and "table updated successfully", which reads exactly like a real run. Signed-off-by: dualfroz <me@dualfroz.com>
dualfroz
requested review from
Altahrim,
CarlSchwan,
leftybournes and
sorbaugh
and removed request for
a team
October 16, 2026 09:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--dry-runflag inocc db:add-missing-indicespartly ignored #39383Summary
with
--dry-runnothing gets changed, but the output still says "this can take some time..." and "table updated successfully", so it looks exactly like a real run (see the last comment on the issue). dry run now prints which indices are missing or would be removed and skips the success line, the SQL is still printed at the end. did the same fordb:add-missing-columnsanddb:add-missing-primary-keys, they had the same pattern.