Repository navigation
feat: allow passing a cache entry to getMetadataForNode - #65586
Merged
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
Altahrim and
salmart-dev
and removed request for
a team
October 16, 2026 15:02
Member
Author
|
/backport to stable35 |
nickvergessen
approved these changes
Oct 16, 2026
3 tasks done
SystemKeeper
approved these changes
Oct 16, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some callers can get an
ICacheEntryfor cheap, but not aNode, and they both have the info we need.Checklist
3. to review, feature component)stable32)AI (if applicable)