Repository navigation
Conversation
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66356 +/- ##
==========================================
+ Coverage 90.49% 90.50% +0.01%
==========================================
Files 797 797
Lines 277811 277833 +22
Branches 53366 53367 +1
==========================================
+ Hits 251407 251455 +48
+ Misses 16795 16763 -32
- Partials 9609 9615 +6
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
marked this pull request as draft
September 29, 2026 16:58
Contributor
|
#66318 is merged, so this can come outof draft |
trivikr
force-pushed
the
vfs-stale-content-open-handles
branch
2 times, most recently
from
October 18, 2026 23:20
c37b211 to
8dae54c
Compare
trivikr
marked this pull request as ready for review
October 18, 2026 23:20
A MemoryFileHandle snapshotted the file's buffer at open and never checked the entry again. After the file changed through the provider or another handle, an open handle served stale reads and fstat sizes, and its writes went into the old copy, undoing other handles' changes. Record the entry content each handle last saw or wrote, and adopt the entry's content whenever another handle has replaced it, so an open descriptor is a live view of the file as on a real filesystem. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
trivikr
force-pushed
the
vfs-stale-content-open-handles
branch
from
October 19, 2026 02:21
8dae54c to
6dcd3df
Compare
Member
Author
|
cc @mcollina Can you take a look? |
trivikr
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66355
A MemoryFileHandle snapshotted the file's buffer at open and never checked the entry again. After the file changed through the provider or another handle, an open handle served stale reads and fstat sizes, and its writes went into the old copy, undoing other handles' changes.
Record the entry content each handle last saw or wrote, and adopt the entry's content whenever another handle has replaced it, so an open descriptor is a live view of the file as on a real filesystem.
Assisted-by: claude:opus-5.5