Skip to content

tools: add --error-on-warn configure flag in test-shared.yml - #66751

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:error-on-warn
Open

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:error-on-warn

Conversation

@aduh95

@aduh95 aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Given that this workflow compiles V8 and other libs separately, that would allow us to detect any Node.js-specific warning that needs to be addressed.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 15, 2026
@panva

panva commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

we better wait to have openssl 3.0 and 1.1 back in the matrix (#66711) and passing before proceeding here

@aduh95

aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Blocked on #66752

@aduh95 aduh95 added blocked PRs that are blocked by other issues or PRs. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 15, 2026
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Oct 20, 2026
Given that this workflow compiles V8 and other libs separately, that
would allow us to detect any Node.js-specific warning that needs to be
addressed.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
   ✖  This PR needs to wait 13 more hours to land (or 0 minutes if there is one more approval)
   ✖  4 GitHub CI job(s) cancelled:
   ✖    - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415345898)
   ✖    - aarch64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415346222)
   ✖    - x86_64-linux: with shared libraries and perfetto / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415346316)
   ✖    - aarch64-linux: with shared boringssl-0.20260929.0 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415347014)

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/66751
�[36m⠋�[39m Loading data for nodejs/node/pull/66751
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66751
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66751
�[36m⠋�[39m Getting comments from nodejs/node/pull/66751
�[36m⠋�[39m Getting commits from nodejs/node/pull/66751
✔  Done loading data for nodejs/node/pull/66751
----------------------------------- PR info ------------------------------------
Title      tools: add `--error-on-warn` configure flag in `test-shared.yml` (#66751)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     aduh95:error-on-warn -> nodejs:main
Labels     tools, author ready, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x
Commits    1
 - tools: add `--error-on-warn` configure flag in `test-shared.yml`
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66751
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66751
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 15 Oct 2026 08:18:30 GMT
   ✔  Approvals: 1
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/66751#pullrequestreview-5604711928
   ✖  This PR needs to wait 13 more hours to land (or 0 minutes if there is one more approval)
   ✖  4 GitHub CI job(s) cancelled:
   ✖    - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415345898)
   ✖    - aarch64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415346222)
   ✖    - x86_64-linux: with shared libraries and perfetto / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415346316)
   ✖    - aarch64-linux: with shared boringssl-0.20260929.0 / build: CANCELLED (https://github.com/nodejs/node/actions/runs/39607169235/job/119415347014)
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants