Skip to content

build: error on incompatible quic configure flags - #66893

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:shared-quic-deps
Oct 23, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:shared-quic-deps

Conversation

@aduh95

@aduh95 aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Follow up of #66754

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 21, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 21, 2026
@github-actions

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 544 -> 543 => +-1 2 / 543 = 0.3%
aarch64-linux 545 -> 544 => +-1 2 / 544 = 0.3%
x86_64-darwin 457 -> 456 => +-1 2 / 456 = 0.4%
aarch64-darwin 470 -> 469 => +-1 2 / 469 = 0.4%
Total 2016 -> 2012 => +-4 8 / 2012 = 0.3%
Changelog
@@ -990,0 +991,4 @@
+/nix/store/h09y86005jnaifb17mda7zky1fy832rp-mock-gtest_main.pc (aarch64-darwin)
+/nix/store/94h0dfrsm4cxhmy5i1lfcxg7qhy770i2-mock-gtest_main.pc (aarch64-linux)
+/nix/store/mlljjpvr7ya9b9w3z87nccfrn3y7fjh0-mock-gtest_main.pc (x86_64-darwin)
+/nix/store/va8cwshfr0gwlxhnads2x2p77kkvgya7-mock-gtest_main.pc (x86_64-linux)
@@ -1015,8 +1018,0 @@
-/nix/store/wgdd6jfvgh4g8ca9rvxpf2szlzhgfmmf-mock-libnghttp3.pc (aarch64-darwin)
-/nix/store/h5wjcs99r61qjf58j9f5q91zh05kcnfm-mock-libnghttp3.pc (aarch64-linux)
-/nix/store/rs4wkb7jlg4985dihlq41j24spd04zr6-mock-libnghttp3.pc (x86_64-darwin)
-/nix/store/szh27mngav6wys666bsmv81fbpsd297f-mock-libnghttp3.pc (x86_64-linux)
-/nix/store/kimjs3076jbqxa73znl2h796sqw282iy-mock-libngtcp2.pc (aarch64-darwin)
-/nix/store/saz1vdkdxxn9flvcqa2bmcwwb114r19f-mock-libngtcp2.pc (aarch64-linux)
-/nix/store/sij9dnjhhrzw7gj5c70gby7398sqy909-mock-libngtcp2.pc (x86_64-darwin)
-/nix/store/c4kbn90kqy6rn6b3gz5lzmh2f8iiglf2-mock-libngtcp2.pc (x86_64-linux)
@@ -1188,4 +1184,4 @@
-/nix/store/0zd98yvcgrgm1l0hmpk85in0wr2pfa36-non-v8-deps-mock-0.0.0-mock (aarch64-darwin)
-/nix/store/zyhyg6zzin9r0zcsfbi3ci0wsw2s5fya-non-v8-deps-mock-0.0.0-mock (aarch64-linux)
-/nix/store/31wl89qg4lniy7kbbldvigkgw5n17mra-non-v8-deps-mock-0.0.0-mock (x86_64-darwin)
-/nix/store/pyc6b26kby0w8csh76swknfss4q5b9s7-non-v8-deps-mock-0.0.0-mock (x86_64-linux)
+/nix/store/3al3f6wmi3smsyrh7qscbq0grsjp2dn5-non-v8-deps-mock-0.0.0-mock (aarch64-darwin)
+/nix/store/6myclm28xz7hmxwzz4nf58rz7jp7by5s-non-v8-deps-mock-0.0.0-mock (aarch64-linux)
+/nix/store/4dnj7pfwim80ijwh6zfdskgpzxb2830j-non-v8-deps-mock-0.0.0-mock (x86_64-darwin)
+/nix/store/9flmgrkhv8j4l97dzmfqcak1jyr5nrp8-non-v8-deps-mock-0.0.0-mock (x86_64-linux)

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 22, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5741b0e into nodejs:main Oct 23, 2026
100 of 102 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 5741b0e

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 23, 2026
@aduh95
aduh95 deleted the shared-quic-deps branch October 23, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants