Skip to content

[Tests] add unit coverage for nvm_version_greater_than_or_equal_to - #3942

Merged
ljharb merged 1 commit into
nvm-sh:masterfrom
shri21955-sketch:test-nvm-version-gte
Oct 7, 2026
Merged

ljharb merged 1 commit into
nvm-sh:masterfrom
shri21955-sketch:test-nvm-version-gte

Conversation

@shri21955-sketch

Copy link
Copy Markdown

Adds a fast unit test for nvm_version_greater_than_or_equal_to, following the existing nvm_version_greater test structure.

Covers:

  • greater version (0.10.0 vs 0.2.12)
  • equal versions
  • leading v on the first argument
  • lesser version
  • empty argument

Test-only change; no behavior change.

@ljharb ljharb changed the title test: add unit coverage for nvm_version_greater_than_or_equal_to [Tests] add unit coverage for nvm_version_greater_than_or_equal_to Oct 7, 2026
@ljharb
ljharb force-pushed the test-nvm-version-gte branch from 6abc080 to 5326eaa Compare October 7, 2026 21:05

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mostly a duplicate of #3941, but there's still some additions left.

@ljharb
ljharb merged commit 5326eaa into nvm-sh:master Oct 7, 2026
452 of 467 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants