Repository navigation
[Fix] install.sh: start a new line before appending to a profile that does not end with one - #3952
Merged
Conversation
…at does not end with one Fixes nvm-sh#3951
ljharb
force-pushed
the
fix/install-profile-missing-newline
branch
from
October 9, 2026 03:56
d61c5b1 to
e45c2df
Compare
ljharb
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the profile already sources
nvm.sh, the installer skips the source block and appends only the bash_completion line. That line has no leading newline, so when the profile doesn't end with one, it gets glued onto the user's last line.The installer now writes a newline first when the profile's last byte isn't one. Added an install_script test that fails without the change.
Fixes #3951