Repository navigation
Fetch discovered JWKS by kid so it can be cached - #219
Open
andrewfader wants to merge 1 commit into
Open
andrewfader wants to merge 1 commit into
andrewfader wants to merge 1 commit into
Conversation
andrewfader
force-pushed
the
cache-jwks-by-kid
branch
from
November 2, 2026 09:32
ade2d40 to
947add3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
discovery: true,decode_id_tokenusesconfig.jwks, which fetches the JWKS on every callback and has no cache.This looks the key up by
kidthroughJSON::JWK::Set::Fetcher, the same pathOpenIDConnect::ResponseObject::IdToken.decodetakes with a discovery config. SettingJSON::JWK::Set::Fetcher.cache(e.g.Rails.cache) then caches the JWKS, and since the cache key includes thekid, a rotated key is fetched again instead of failing. Tokens without akidand non-discovery setups are unchanged. Note the fetch for this path goes throughJSON::JWK::Set::Fetcher.http_clientrather thanOpenIDConnect.http_client.Tests: a discovery callback run twice fetches the JWKS once (fails before this change, 2 requests), and a callback signed with a newly rotated key succeeds.
Based on #124 by @nov, on current
master.