Skip to content

enable mutation tools - #1836

Merged
nikhilsinhaparseable merged 2 commits into
parseablehq:mainfrom
nikhilsinhaparseable:mutation-tools
Oct 29, 2026
Merged

nikhilsinhaparseable merged 2 commits into
parseablehq:mainfrom
nikhilsinhaparseable:mutation-tools

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • AI tool integrations can create, update, and delete dashboards; add dashboard tiles; and manage alerts and alert targets.
    • The tool registry now lists both read-only and action tools together.
  • Improvements
    • Dashboard tile changes now reject nil or duplicate tile IDs.
    • Action-tool updates accept complete specifications, while create, save, and delete actions require fewer inputs.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 1313edbb-58e6-487d-a6f0-d515a5c4f732
Commits

Reviewing files that changed from the base of the PR and between e265f38 and d62bd45.

Files selected for processing: 1
  • src/tool_executor.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The OSS tool catalog now combines read and effectful tools, and the registry exposes the combined set. The executor handles alert, target, and dashboard mutations. HTTP handlers expose reusable internal functions for these operations, with dashboard access and tile-ID validation in the helpers.

Changes

OSS Tool Mutations

Layer / File(s) Summary
Combined tool catalog
src/tool_catalog.rs
The catalog combines read and effectful tools. Mutation schemas and registry and catalog tests use the combined catalog.
Reusable mutation handlers
src/handlers/http/alerts.rs, src/handlers/http/targets.rs, src/handlers/http/users/dashboards.rs
Alert and target operations, and dashboard creation, lookup, update, deletion, and tile addition, are exposed through internal functions. Dashboard helpers perform access checks and tile-ID validation.
Mutation execution and dispatch
src/tool_executor.rs
The executor resolves session users, authorizes and runs alert, target, and dashboard mutations, and dispatches the corresponding tool names.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant MCPEndpoint
  participant ToolExecutor
  participant Users
  participant InternalOperations
  MCPEndpoint->>ToolExecutor: Validate tool name and arguments
  ToolExecutor->>Users: Authorize mutation and resolve session user
  Users-->>ToolExecutor: Return authorization and user context
  ToolExecutor->>InternalOperations: Call alert, target, or dashboard helper
  InternalOperations-->>ToolExecutor: Return operation result
  ToolExecutor-->>MCPEndpoint: Return tool result
Loading

Possibly related PRs

Suggested reviewers: parmesant

Merge Risk: Minimal · up to d62bd

No demonstrated issue blocks merging, subject to normal checks.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning No pull request description was provided. The required description, issue reference when applicable, change summary, testing status, comments, and documentation status are missing. Add a pull request description with the required sections. Include the goal, chosen solution and rationale, key changes, issue reference if applicable, testing status, comments status, and documentation status.
Docstring Coverage Warning Docstring coverage is 22.58% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: enabling mutation tools. It is concise and related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 22.58% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 31 functions across 5 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the tool list twice,
Then sends a change with care and mice.
Alerts and dashboards find their way,
Targets update through the day.
The burrow logs each action neat,
And hops away on quiet feet.

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 28, 2026
@nikhilsinhaparseable
nikhilsinhaparseable merged commit ea8e0ea into parseablehq:main Oct 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants