Repository navigation
enable mutation tools - #1836
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Combined tool catalog src/tool_catalog.rs |
The catalog combines read and effectful tools. Mutation schemas and registry and catalog tests use the combined catalog. |
Reusable mutation handlers src/handlers/http/alerts.rs, src/handlers/http/targets.rs, src/handlers/http/users/dashboards.rs |
Alert and target operations, and dashboard creation, lookup, update, deletion, and tile addition, are exposed through internal functions. Dashboard helpers perform access checks and tile-ID validation. |
Mutation execution and dispatch src/tool_executor.rs |
The executor resolves session users, authorizes and runs alert, target, and dashboard mutations, and dispatches the corresponding tool names. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant MCPEndpoint
participant ToolExecutor
participant Users
participant InternalOperations
MCPEndpoint->>ToolExecutor: Validate tool name and arguments
ToolExecutor->>Users: Authorize mutation and resolve session user
Users-->>ToolExecutor: Return authorization and user context
ToolExecutor->>InternalOperations: Call alert, target, or dashboard helper
InternalOperations-->>ToolExecutor: Return operation result
ToolExecutor-->>MCPEndpoint: Return tool result
Possibly related PRs
- parseablehq/parseable#1615: Both PRs change alert-target mutation behavior, including target update validation.
- parseablehq/parseable#1651: The lock-type change affects the
stream.metadataread in this PR’s tool-executor path. - parseablehq/parseable#1685: Both PRs change the session authorization flow used by
Users.authorize.
Suggested reviewers: parmesant
Merge Risk: 
Minimal · up to d62bd
-
No demonstrated issue blocks merging, subject to normal checks.
Pre-merge checks: 
3 · 
2
-
Failed checks: 2 warnings Passed checks: 3 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 22.58% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 31 functions across 5 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the tool list twice,
Then sends a change with care and mice.
Alerts and dashboards find their way,
Targets update through the day.
The burrow logs each action neat,
And hops away on quiet feet.
Comment @coderabbitai help to get the list of available commands.
Summary by CodeRabbit