Repository navigation
Conversation
Descolada
marked this pull request as ready for review
October 27, 2026 06:08
Contributor
Author
|
So... I have like almost 50 changes made on my keysharp-org/Eto, most are bug-fixes or bring parity across platforms. I'll try to make PRs for as many as I have time and energy for (even with AI support), let me know if it gets too much :) |
Cache the assigned title instead of reconstructing it from Gtk.Label.Text, which returns display text after mnemonic and escape processing. Normalize null to empty and retain native mnemonic conversion when updating the label. Keep two small round-trip cases for authored title text and null. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Descolada
force-pushed
the
upstream/gtk-tabpage-text
branch
from
October 27, 2026 09:02
0b298e7 to
6ff6763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading
TabPage.Texton GTK reconstructs the title fromGtk.Label.Text, which has already processed mnemonic markers and escaped literals. For example, assigning"&File"returns"File", and literal underscores can be converted into ampersands.Cache the assigned title, normalize null to an empty string, and return it directly, following the GTK button and label handlers. Keep native mnemonic conversion in the setter.
Keeps two small round-trip cases: one title containing mnemonic markers and escaped literals, and one null title. Both pass on Ubuntu under WSL with .NET 10 and GTK3 on Xvfb;
ManualTestexcluded.git diff --checkpasses.