Repository navigation
Conversation
Descolada
marked this pull request as ready for review
October 27, 2026 07:05
Add Super_L and Super_R aliases while retaining the existing Meta keys as the canonical reverse mappings.
Descolada
force-pushed
the
upstream/gtk-super-keys
branch
from
October 27, 2026 08:57
015f263 to
5d60f6d
Compare
Member
|
Hm, what about Meta_L/R? Doing a quick search says it is usually mapped to the same as to Alt_L/R. Should it be removed from the mapping? |
Prefer Super when converting application keys back on Linux and other Unix systems. Keep Meta on Windows and macOS while retaining both input aliases.
Contributor
Author
|
Valid point, as GTK’s mapping varies by platform:
I've added a commit to prefer Super by default, with Meta for Windows and macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK's key map omits
Super_LandSuper_R, so input conversion loses the left/right identity of those keys.Map them to the corresponding Eto application keys. Keep the existing Meta aliases first to preserve canonical reverse conversion.
Validation: native GTK3 key conversion checked on Linux with .NET 10 and Xvfb;
git diff --checkpasses.