Repository navigation
Conversation
Handle missing label widgets when accessing ClientSize and TextColor. Cache explicit text colors and reapply assigned font and color whenever GTK creates a label after a title change. Keep one GTK regression test for deferred styles and title replacement.
Descolada
marked this pull request as ready for review
October 27, 2026 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing
ClientSizeorTextColoron a GTK GroupBox before it has a title dereferences a missing label. Handle the absent label when sizing, use the frame's default foreground, and retain explicitly assigned colors until a label exists.GTK replaces the label on each title assignment. Reapply assigned font and color so renaming a title or clearing and restoring it preserves styling, including an explicitly transparent color.