Repository navigation
Gtk: Allow ComboBox controls to honor narrow explicit widths - #3127
Merged
Merged
Conversation
Remove the entry's default minimum width when an explicit width is set, matching TextBoxHandler. Restore the native default for automatic sizing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK's embedded entry minimum prevents a ComboBox from honoring narrow explicit widths, allowing it to crowd adjacent controls.
Apply the same
WidthCharspolicy asTextBoxHandler: zero for an explicit width, and -1 when returning to automatic sizing. Keep the existing dropdown and base sizing behavior.Validated on Ubuntu under WSL with .NET 10, GTK3 and Xvfb using a temporary shown layout:
Width = 80allocates 80 pixels (upstream still allocates 203), thenWidth = -1restores the original 203-pixel automatic width.