Repository navigation
Gtk: Filter keys through an input context only when needed - #3128
Merged
Merged
Conversation
Reuse the focus-in condition when filtering key presses, so key-only handlers do not create an auxiliary context. Keep the existing TextInput and Drawable composition paths, including lazy creation after focus.
Member
|
Looks good! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controls listening only to
KeyDowncurrently create and filter an auxiliary input context even when no Eto text-input consumer exists. Native text widgets already handle their own text input.Reuse the existing focus-in condition for key filtering: only
TextInputconsumers or Drawable composition need the auxiliary context. Preserve lazy creation whenTextInputis attached after the control has focus.