Repository navigation
Conversation
Include layout offsets when a control shares an ancestor's native window. Use the same origin for both screen conversions and fall back to the realized toplevel origin for unrealized children. Preserve Button input-window coordinates so mouse-event conversions retain their existing behavior, including inset native input windows.
Descolada
marked this pull request as ready for review
October 27, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A windowless GTK control can share an ancestor's native window, so using that window's origin loses the control's layout offset. Translate through the toplevel widget and use the resulting screen origin for both
PointToScreenandPointFromScreen.For unrealized children, fall back to the realized toplevel's origin; detached controls retain identity conversion. Preserve the existing Button input-window origin so mouse-event coordinates still round-trip when the native input window is inset.