Repository navigation
Gtk: Avoid retaining window handlers in queued Shown callbacks - #3133
Merged
Merged
Conversation
Resolve the handler through the weak connector when the queued callback runs, instead of capturing it strongly. Preserve the existing closed-window guard and child-before-window Shown ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a GTK window closes while its
Showncallback is queued, capturing the handler keeps it alive until the callback runs. Resolve the handler through the existing weak connector at dispatch time instead, retaining the closed-window guard and normal child-before-window event order.The queued
Showncallback previously captured the handler strongly, keeping the window and its managed state alive until dispatch, even after closure. Resolving the handler through the existing weak connector allows collection while the callback remains queued and safely skips notification if the handler is gone. This avoids unnecessary temporary retention and follows the existing weak-event design used elsewhere.