Repository navigation
Conversation
logaretm
changed the title
Member
|
You can use my PR, no problem. You have commit access, so you can use the GitHub CLI to push to my branch |
Member
Author
|
We can keep them separate to avoid muddying your PR, will rebase/undraft this PR once yours merges! If you think it belongs there, then happy to push it. Up to you. |
Member
|
Hmm, I’m not sure. If you want, take a look at my PR. How about we give Ulises and the other reviewers a week to review it, then merge it and take a look at yours? |
Member
|
please rebase |
logaretm
force-pushed
the
awad/tracing-route-pattern
branch
from
October 22, 2026 15:29
4896d50 to
27974cb
Compare
logaretm
marked this pull request as ready for review
October 22, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracing subscribers couldn't tell which route pattern matched a request, fixed by adding a
routefield to theexpress.router.requestcontext, built onrawPathfrom #174.I added tests for middleware, route handlers, route error handlers, mounted routers, and array paths where only one entry matches.