Repository navigation
Fix default and named type-only imports - #58
Open
mayankdhingra02 wants to merge 1 commit into
Open
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #57
❓ Type of change
📚 Description
ImportsBagcurrently emitsimport type Default, { Named } from 'package'when a source has both kinds of type imports. TypeScript rejects this with TS1363. Emit separate default and named type declarations while keeping value imports and deduplication unchanged.Correct the combined-output expectation and check generated imports with the TypeScript compiler, including both merge orders, aliases and mixed value/type imports.
Validation:
npm test(212 passing),npm run typecheckandnpm run buildpass on Node 24.22.1 and 26.12.1 on macOS. Formatting and lint also pass. Linux and Windows CI were not run locally. The lodash build reports that Java's Closure Compiler is unavailable and completes with UglifyJS.📝 Checklist