Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script collecting results from multiple
bench_func()calls also runs in workers, where skipped benchmarks returnNone. Add theRunner.is_worker()helper requested in #166 so callers can guard result processing such as building aBenchmarkSuite.The method uses the existing cached argument parser. The API documentation includes a guarded example, and tests cover detection before/after argument parsing plus a real two-benchmark script re-executed in workers. Benchmark execution and return values are unchanged.
Validation on macOS with Python 3.13.12:
AttributeErrorinBenchmarkSuite; the guarded script succeeds and builds the suite only in the main process.pyperf.tests.test_runnerpass, including the two new tests.test_python_optionfails because copying this uv-managed interpreter loses its@rpath/libpython3.13.dyliblocation; the same test fails identically against unmodified HEAD.staticdirectory warning. Ruff reports the same 14 existing diagnostics in the two Python files before and after the patch, with no new diagnostics.git diff --checkpasses.Prepared with Codex assistance.
Refs #166; follows the narrow scope requested after #222 was closed.