Repository navigation
Conversation
…pterodactyl#4026) Signed-off-by: Saik2789 <[EMAIL_REDACTED]>
Contributor
|
Hi, I do not review PRs with descriptions that are purely written with AI, please see: https://github.com/pterodactyl/panel/blob/1.0-develop/CONTRIBUTING.md |
Author
|
Hey Robert (@robertdrakedennis), completely understood and point taken! I have updated the description to be clear and concise in my own words. The implementation itself is solid and fully verified:
I cannot reopen the PR myself since maintainer closure locks it, but if you're open to reviewing the actual code and tests, feel free to reopen or let me know if you prefer any specific adjustments to the architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4026
/claim #4026
Added support for reverse proxy header authentication (e.g. Authelia, Authentik, Cloudflare Access) behind trusted proxies.
Summary
AuthenticateWithHttpHeadermiddleware in thewebgroup to inspect configured user/email headers when requests originate from trusted CIDRs/proxies.UserCreationServicewhen configured.config/pterodactyl.phpand.env.example.tests/Unit/Http/Middleware/AuthenticateWithHttpHeaderTest.phpandtests/Integration/Http/Controllers/Auth/AuthenticateWithHttpHeaderTest.php. All PHPUnit tests and code styling pass clean.Payout Address
Wallet (USDC): 0x20A0525b47f087f1Cc498cda257A0feB78D2320B (Base, Polygon, Arbitrum)
Contact: Saik2789@users.noreply.github.com