Repository navigation
Fix CUDA feature test to expect the CUDA_VERSION the feature exports - #798
Merged
Merged
Conversation
The feature derives CUDA_VERSION from the CUDA_VERSION macro in cuda.h (13040), which yields 13.4.0, not the 13.4.3 toolkit release.
KyleFromNVIDIA
approved these changes
Oct 20, 2026
KyleFromNVIDIA
left a comment
KyleFromNVIDIA
left a comment
Member
There was a problem hiding this comment.
Approved with one note: it would be nice to modify this script to put the expected CUDA version in a single variable and parse it out. Having it spread across multiple lines like this is ugly.
trxcllnt
approved these changes
Oct 20, 2026
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#793 set the test to expect
CUDA_VERSION=13.4.3andCUDA_VERSION_PATCH=2, but the feature derivesCUDA_VERSIONfrom theCUDA_VERSIONmacro incuda.h(13040), which yields13.4.0. This fixes theTest cuda featurejobs failing onmain.