Skip to content

Fix RAPIDS version replacement in release updater - #918

Closed
msarahan wants to merge 1 commit into
rapidsai:release/26.10from
msarahan:fix/rapids-ver-version-regex
Closed

msarahan wants to merge 1 commit into
rapidsai:release/26.10from
msarahan:fix/rapids-ver-version-regex

Conversation

@msarahan

@msarahan msarahan commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

This regex is wrong and can allow invalid versions like 26.1006.

@msarahan
msarahan requested a review from a team as a code owner October 8, 2026 08:00
@copy-pr-bot

copy-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@msarahan
msarahan requested review from josephine-wolf-oberholtzer and removed request for KyleFromNVIDIA October 8, 2026 08:00
@msarahan msarahan added bug Something isn't working non-breaking labels Oct 8, 2026

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's merge this.

When the release is over, worth checking if #909 has anything else that should be included (if so, it'd be nice to give that contributor a commit), and if this is enough for #907 to be closed.

@josephine-wolf-oberholtzer

Copy link
Copy Markdown

/ok to test a16f848

@copy-pr-bot

copy-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

/ok to test a16f848

@josephine-wolf-oberholtzer, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@msarahan

msarahan commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

closing in favor of #909

@msarahan msarahan closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants