Repository navigation
Drop Python 3.11 support - #1092
Merged
Merged
Conversation
jameslamb
added
non-breaking
27 of 28 tasks
jameslamb
marked this pull request as ready for review
October 9, 2026 14:14
KyleFromNVIDIA
approved these changes
Oct 9, 2026
jameslamb
commented
Oct 9, 2026
| - output_types: [requirements, pyproject] | ||
| packages: | ||
| - "zarr>=3.0.0,<3.2.0,<4.0.0; python_version >= '3.11'" | ||
| - zarr>=3.0.0,<3.2.0,<4.0.0 |
Member
Author
There was a problem hiding this comment.
Re-reviewing this diff before merging I realized... we don't need this environment marker any more.
It was added at a time when RAPIDS still supported Python 3.10 and zarr didn't have Python 3.10 wheels for this range of versions.
ref: https://github.com/rapidsai/kvikio/pull/802/changes#r2285936739
It could have been dropped when we we dropped Python 3.10, and definitely can now.
Member
Author
There was a problem hiding this comment.
Sorry @KyleFromNVIDIA for pushing a change after you'd already reviewed, lmk what you think
KyleFromNVIDIA
approved these changes
Oct 9, 2026
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#341
Drops Python 3.11 support.
Notes for Reviewers
How I tested this
Checked that there were no remaining uses like this:
git grep -E '3\.11|311'