Repository navigation
Declare dependencies and announce 4.0's breaking changes (3.7.0) #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae7b1a5
Declare activerecord as a runtime dependency
schlick 9027f48
Add a gem-owned deprecator
schlick d3af0dc
Announce the Sidekiq, Ruby and Rails versions 4.0 will require
schlick adff0f2
Declare gem metadata URIs
schlick 3fbd600
Remove the unused publish workflow
schlick c21d626
Drop the unused GitHub Packages permission
schlick 21cd1b6
Make the development container usable and add a devcontainer
schlick d01439f
Ship only the files a consumer needs
schlick 5b75da9
Ignore vendored bundles
schlick f382102
Lead the README with what the gem does
schlick 3e56452
Deprecate the Capistrano integration and cover its entry point
schlick b456fb3
Announce that slack-notifier becomes the host's dependency in 4.0
schlick 9b8258a
Exclude version.rb from the coverage requirement
schlick 9c062f9
Release 3.7.0
schlick 0eec058
Address PR feedback on 3.7.0
schlick daad44e
Reset the configuration before the Slack deprecation examples
schlick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "name": "patches", | ||
| "dockerComposeFile": "../docker-compose.yml", | ||
| "service": "app", | ||
| "workspaceFolder": "/app", | ||
| "overrideCommand": true, | ||
| "postCreateCommand": "bundle install", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": ["Shopify.ruby-lsp"] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Gemfile.lock is not committed, so copying a locally-resolved one would pin the | ||
| # image to whatever the host last used. .git is deliberately NOT excluded: the | ||
| # gemspec builds spec.files from `git ls-files`. | ||
| Gemfile.lock | ||
| .bundle | ||
| vendor | ||
| coverage | ||
| test.db | ||
| *.gem | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ | |
| /test.db | ||
| /*.gem | ||
| .byebug_history | ||
| /vendor/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| FROM ruby:2.3 | ||
|
|
||
| RUN touch ~/.gemrc && echo "gem: --no-ri --no-rdoc" >> ~/.gemrc | ||
| # Development container for working on the gem. The Ruby version can be | ||
| # overridden to reproduce any cell of the matrix in README.md: | ||
| # | ||
| # docker compose build --build-arg RUBY_VERSION=3.1 | ||
| ARG RUBY_VERSION=3.4 | ||
| FROM ruby:${RUBY_VERSION} | ||
|
|
||
| WORKDIR /app/ | ||
| ADD . /app/ | ||
| COPY . /app/ | ||
| RUN bundle install | ||
|
|
||
| CMD bundle exec rake -T | ||
| CMD ["bundle", "exec", "rspec"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| require 'patches/deprecation' | ||
|
|
||
| Patches.warn_capistrano_support_removed_in_4_0 | ||
|
|
||
| load File.expand_path("capistrano/tasks.rake", File.dirname(__FILE__)) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also adds
/vendor/to.gitignore(for a locally vendored bundle path), but.dockerignoreisn't updated to match. If a dev vendors gems locally (bundle config set --local path vendor/bundle) and then runsdocker compose build, the fullvendor/bundletree gets sent as build context and copied into the image — unnecessary bloat given gems are already stored via the compose volume. Consider addingvendorhere too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[AI] Fixed in 0eec058 —
vendoradded to.dockerignore, so the two files agree.You are right about the mechanism: the build context is what gets sent, and
COPY . /app/would then bake a vendored tree into the image, on top of the gems the compose volume already holds at/usr/local/bundle.For what it is worth, the
/vendor/entry in.gitignoreis itself belt-and-braces — nothing in the committed config vendors gems locally, andruby/setup-rubyonly does it inside an ephemeral runner workspace. But if someone does adopt the habit, both files now cover it.