Repository navigation
Build the Nix package against non-interactive bash - #9
Merged
Merged
Conversation
On nixos-26.05, `bash` is the interactive build, which drags readline, ncurses and libiconv into the package's closure (55.9 MiB instead of 2.8 MiB on aarch64-darwin). The script doesn't need any of that, so it uses bashNonInteractive now, like the nixpkgs 0.2.0 update. The dev shell adds bashInteractive back so `bash` there still has line editing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On nixos-26.05,
bashis the interactive build. Having it inbuildInputspulled readline, ncurses and libiconv into the package's closure and gave the script abash-interactiveshebang:bash)bash-interactive-5.3p9bashNonInteractive)bash-5.3p9The script doesn't use any interactive-bash features, and this matches the nixpkgs 0.2.0 update (NixOS/nixpkgs#567054).
Since the dev shell takes the package's inputs,
bashinsidenix developwould have become the non-interactive build too, so the dev shell addsbashInteractiveback.make checkandnix flake checkpass locally.🤖 Generated with Claude Code