Repository navigation
fix: lock releases for after the CCA keys leak problem - #967
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 84 84
Lines 10977 10977
=======================================
Hits 10713 10713
Misses 264 264 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This should avoid developers and contributors to have old possible comprimissed vversions of our package manager related dependencies
bb1b905 to
cf547c4
Compare
|
I've done "uv python install 3.12.13" within my own environment. I don't know if that needed to be done (or mentioned in readme).
I had previously updated to latest astral-uv by uninstalling via snap manager and re-installing latest in user-space. Thank you for this @joaozinhom. |
|
cACK, i will do a proper review offline |
There was a problem hiding this comment.
Concept ACK, but breaks docker build + lock is stale, see inline.
not blocking:
- actions pinned by tag, codecov/gh-pages get secrets. pin to SHAs
psf/black@stableis a moving tag, deps unpinned- Dockerfile:
astorunpinned,pyserial==3.4no hash - develop has no uv pin, main not merged back
qlrd
left a comment
There was a problem hiding this comment.
Just nits, and i have more doubts on pin first to main then back to develop:
notTanveer
left a comment
There was a problem hiding this comment.
a few questions
- uv lock --check fails on this branch. requires-python in the lock header is still >=3.11.5 and there's no [manifest] constraints entry for certifi. did you run uv lock? ci uses --frozen so it won't catch it
- is requires-python >=3.11.17 meant to be a hard install gate? anyone on 3.11.5-3.11.16 (distro python) gets an error now. or should only ci pin the patch version?
- why constraint-dependencies for certifi instead of just bumping the lock? it makes uv.lock depend on a pyproject.toml entry we'd have to remember to drop later
- the dockerfile fetches wheels from files.pythonhosted.org/packages/py3/p/.... it works (hashes match), but it's a legacy redirect and not a documented api. would pip install --require-hashes -r with a requirements file work instead?
56de6e6 to
1f29f7d
Compare
Thanks, I pushed updates addressing these points:
I also ran the lock check, lint, formatting check, and test suite. Everything passes with 1193 tests passed and the existing expected xfail. |
I don't have a strong opinion. Locking should reduce some risks, but adds complexity and complicates maintenance. |
We already implement version pinning for cases such as Python versions prior to 3.10 (due to breaking changes, such as f-strings and new methods like |
qlrd
left a comment
There was a problem hiding this comment.
No block on those, but IMO is good to update
1f29f7d to
e1961d0
Compare
|
ACK on these changes to be merged into "main", and later into "develop". |
This should avoid developers and contributors to have old possible compromise versions of our package manager related dependencies
What is this PR for?
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?