Repository navigation
docs: fix dead links to plugin and offline READMEs breaking pages deploy - #1077
Open
curnane-lab wants to merge 2 commits into
Open
curnane-lab wants to merge 2 commits into
curnane-lab wants to merge 2 commits into
Conversation
The capture PR series linked to plugins/sglang-spec-capture/README.md and examples/offline/README.md with repo-relative paths, which escape the VitePress srcDir (docs/) and fail the build with 10 dead links. Use the absolute GitHub blob URLs like the rest of the docs.
4 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The capture PR series (#1064, #1065, #1066) linked to
plugins/sglang-spec-capture/README.mdandexamples/offline/README.mdwith paths relative todocs/. VitePress only resolves links inside itssrcDir(docs/), so those targets are dead links and the pages deploy fails. The latest failure is the #1066 push to main: Release Documentation reports exactly these 10 links.PR Teston this pull request fails inunit-testwithdubious ownership. That comes from #1066 and is fixed separately in #1078. This change is documentation only.Modifications
Replace the 10 repo-relative links with absolute GitHub blob URLs on
main, the same form already used for other files outsidedocs/(configs, gate scripts):plugins/sglang-spec-capture/README.md: the three disaggregated recipes, AMD, Ascend, and installation.examples/offline/README.md: AMD, data preparation, DFlash2, and the Llama3 EAGLE3 offline example.Related Issues
Follow-up to #1064, #1065, and #1066. No open issue. The unrelated unit-test failure is #1078.
Accuracy Test
Not applicable. Documentation links only.
Benchmark & Profiling
Not applicable. Documentation links only.
Checklist