Repository navigation
fix: adds test cases - #24120
Merged
Merged
fix: adds test cases#24120
Conversation
TestCoordinator_DeliverAdmission built its denial from a lookalike error, not the shard-denial sentinels, so it still expected admission_denied after the coordinator started counting shard denials by reason. Cover not-owner, orchestrator error and a plain denial with the real sentinels, and compare drops across every reason so a drop counted under the wrong one fails. Refs: CRE-6178
Only the not-owner shard denial ran on the coordinated path. The orchestrator-error and plain denials were tested on legacy alone, though the coordinator counts all three through CountAdmissionDenied. Add TestEngine_AdmissionDenialParity, which runs every denial on both engines and checks the ACK, the drop reason, both shard-denial counters, and that no execution or execution event follows. It replaces TestEngine_AdmissionDenial_ShardDenialCounters and the ShardDenied drop-reason scenario. It waits a fixed 5s, so a failure no longer waits out the test deadline. The lifecycle harness now records each engine's beholder messages. Refs: CRE-6178
Contributor
|
✅ No conflicts with other open PRs targeting |
MStreet3
merged commit Oct 30, 2026
5bc3a99
into
CRE-6178_parity_validation_testsuite
56 of 57 checks passed
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports
Deployment Validation Steps