Repository navigation
Translate API Errors - #6702
Merged
jarednorman merged 5 commits intoOct 19, 2026
Merged
Translate API Errors#6702jarednorman merged 5 commits into
jarednorman merged 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6702 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 1058 1058
Lines 21493 21493
=======================================
Hits 19873 19873
Misses 1620 1620 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvdeyen
reviewed
Oct 17, 2026
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Great change. Thanks. I have a suggestion about using translations in specs. Not sure how we handled this in the past.
jarednorman
force-pushed
the
api-error-assertions-use-translations
branch
from
October 17, 2026 20:09
88c26aa to
ecdf1ed
Compare
tvdeyen
approved these changes
Oct 18, 2026
AlistairNorman
approved these changes
Oct 19, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@benjaminwil had a good idea here: the API responses weren't consistently translated and should be. The ones I was changing were translated in the partials, but not the helpers. This PR fixes that and makes our tests consistent in asserting against translated errors from the API.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: