Repository navigation
Make externalDocs/url absolute in OpenAPI during bundling - #925
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Makes OpenAPI documentation links retain their targets when bundled documents move.
🤖 Was this summary useful? React with 👍 or 👎 |
| sourcemeta::core::JSON::String restored{annotation}; | ||
| this->renames_.emplace_back(sourcemeta::core::Pointer{parked}, | ||
| sourcemeta::core::Pointer{restored}); | ||
| schema.rename(parked, std::move(restored)); |
There was a problem hiding this comment.
Could you check the generated-name case at vendor/blaze/src/convert/rules/carried_annotation_becomes_keyword.h:45? In an OpenAPI 3.0 Reference Object, an ignored sibling "sourcemeta-carried-readOnly": "data" becomes x-sourcemeta-carried-readOnly in UpgradeOpenAPI30ToDraft4::shadow() after the reservation pre-pass, so this phase promotes it into a non-boolean readOnly, producing an invalid Draft 2020-12 schema from previously ignored data.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com