Skip to content

[FuSa] Separate trigger and system change impact analyses - #1442

Open
devashridatta-dotcom wants to merge 58 commits into
spdx:developfrom
devashridatta-dotcom:agent/fusa-reassessment-source
Open

devashridatta-dotcom wants to merge 58 commits into
spdx:developfrom
devashridatta-dotcom:agent/fusa-reassessment-source

Conversation

@devashridatta-dotcom

@devashridatta-dotcom devashridatta-dotcom commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the FunctionalSafety model to distinguish between analyzing system impact and documenting the accomplishment of system changes.

Model

  • AnalysisTrigger identifies an event, finding, report, or condition that prompts an analysis.
  • SystemImpactAnalysis assesses one or more triggers or source artifacts and may conclude that no change is required.
  • SystemChangeAccomplishmentSummary documents the accomplishment of actual or proposed system changes and supporting assurance evidence.

System Change Accomplishment Summary

The renamed class incorporates concepts from the DO-178C Software Accomplishment Summary (SAS), including:

  • System and software overview.
  • Certification considerations.
  • Software lifecycle and lifecycle data.
  • Supplier oversight.
  • Software identification and characteristics.
  • Change history.
  • Software status and unresolved problems.
  • Compliance statement and deviations from the approved PSAC system overview.

These concepts are provided as cross-domain documentation guidance. They do not assert DO-178C compliance or introduce mandatory SAS-specific properties.

Existing SPDX elements and relationships are reused for supporting evidence.

No additional classes are introduced as part of this change.

@devashridatta-dotcom
devashridatta-dotcom force-pushed the agent/fusa-reassessment-source branch from 18744d4 to d8fd642 Compare August 28, 2026 19:17
@devashridatta-dotcom devashridatta-dotcom changed the title [FuSa] Add reassessment source for safety assessments [FuSa] Add ChangeTrigger and ChangeImpact for safety change analysis Aug 28, 2026
@devashridatta-dotcom
devashridatta-dotcom force-pushed the agent/fusa-reassessment-source branch from d8fd642 to d60c650 Compare August 28, 2026 20:01
@devashridatta-dotcom devashridatta-dotcom changed the title [FuSa] Add ChangeTrigger and ChangeImpact for safety change analysis [FuSa] Add ChangeTrigger and ChangeImpactAnalysis for safety change analysis Aug 28, 2026
@goneall goneall added the Profile:FuSa FunctionalSafety profile and related matters label Aug 28, 2026
@goneall goneall added this to the 3.1-rc2 milestone Aug 28, 2026
@devashridatta-dotcom
devashridatta-dotcom marked this pull request as ready for review September 2, 2026 18:47

@kestewart kestewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make a couple of decisions to remove ambiguity.

Signed-off-by: stevenc-stb <steven@smarttalkbeacon.com>
Signed-off-by: stevenc-stb <steven@smarttalkbeacon.com>

@nicpappler nicpappler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeImpactAnalysis needs more rework, that we have to discuss in the meetings. Also we need to make sure that the ChangeTrigger can really represent all information sources that might trigger a change. Maybe make it an Element instead of an Artifact. The impact analysis description also has to move somewhere else, it is crowding now the FunctionalSafety.md file.

@devashridatta-dotcom

Copy link
Copy Markdown
Contributor Author

Updated after the latest FuSa discussion:

  • removed \�pprovedBy\ from \ChangeImpactAnalysis, since approval belongs in a future decision model rather than the analysis artifact itself;
  • removed
    ejected\ from \ChangeImpactAnalysisStatusType, since rejection is a decision outcome rather than a lifecycle status of the analysis;
  • kept \ChangeTrigger\ as a /Core/Artifact\ and kept /Core/rationale\ only on \ChangeImpactAnalysis\ for the overall reason/scope/conclusion;
  • left element-level decision state, approval/rejection outcomes, lifecycle rerun tracking, and closure evidence for a follow-up decision-model PR.

PR #1443 has also been aligned so the examples no longer use \�pprovedBy.

@devashridatta-dotcom

Copy link
Copy Markdown
Contributor Author

@kestewart @nicpappler could you please re-review PR #1442 for approval/merge? The branch is now clean and both checks are passing.

I updated the PR after the FuSa discussion to keep the scope narrow:

  • PR [FuSa] Separate trigger and system change impact analyses #1442 now focuses only on ChangeTrigger and ChangeImpactAnalysis plus the supporting properties and vocabularies.
  • approvedBy was removed from ChangeImpactAnalysis because approval belongs in a future reusable Decision model.
  • rejected was removed from ChangeImpactAnalysisStatusType because rejection is also a decision outcome, not an analysis lifecycle state.
  • element-level decisions, lifecycle rerun tracking, closure evidence, and detailed guidance are intentionally left for a follow-up Decision PR.

If this scope looks acceptable, could you approve so we can merge PR #1442 and continue the Decision work separately?

@chuckwolber chuckwolber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this document is attempting to do two things at once. I recommend splitting it up. See comments for more detail.

Comment on lines +18 to +20
An AnalysisTrigger does not assert that a change is required. It records why a
SystemImpactAnalysis is opened so the analysis can determine whether affected
elements need to be added, removed, revised, verified, or left unchanged.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you managed to hit all the possibilities, but would it make more sense to speak more generally to avoid interpretation errors?

Suggested change
An AnalysisTrigger does not assert that a change is required. It records why a
SystemImpactAnalysis is opened so the analysis can determine whether affected
elements need to be added, removed, revised, verified, or left unchanged.
An AnalysisTrigger does not assert that a change is required. It records why a
SystemImpactAnalysis is opened so the analysis can determine whether the design
needs to be modified.

Comment on lines +22 to +26
When the source is already represented by a more specific SPDX Artifact, that
existing element can be used as input to the SystemImpactAnalysis. For example,
a CVE can be represented using /Security/Vulnerability, which is a subclass of
/Core/Artifact and can carry an externalIdentifier with externalIdentifierType
`cve`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it is out of scope for an analysis trigger description. Should it be moved to the SystemImpactAnalysis description?

Comment on lines +28 to +32
The authoritative record for the trigger can be referenced using inherited
/Core/externalRef or /Core/externalIdentifier values. For example, the trigger
can point to an FAA report, CAPA record, QMS record, Jira issue, ServiceNow
ticket, or other externally managed record without duplicating that system's
contents in SPDX.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be more detail when it comes to referencing an external system of record. Possibly even modeling how specific systems of record like Jira would be referenced.

Comment on lines +11 to +12
SystemImpactAnalysis represents the documented analysis of one or more analysis
triggers against SPDX elements.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which SPDX elements are you referring to? Would it work to just remove that part?

Suggested change
SystemImpactAnalysis represents the documented analysis of one or more analysis
triggers against SPDX elements.
SystemImpactAnalysis represents the documented analysis of one or more analysis
triggers.

Comment on lines +14 to +17
A SystemImpactAnalysis can be linked to one or more AnalysisTrigger elements
using a /Core/Relationship with relationshipType `hasInput`, from the
SystemImpactAnalysis to each AnalysisTrigger. This keeps the source or reason
for the analysis separate from the analysis that determines impact.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A SystemImpactAnalysis can be linked to one or more AnalysisTrigger elements
using a /Core/Relationship with relationshipType `hasInput`, from the
SystemImpactAnalysis to each AnalysisTrigger. This keeps the source or reason
for the analysis separate from the analysis that determines impact.
A SystemImpactAnalysis can be linked to one or more AnalysisTrigger elements
using a /Core/Relationship with relationshipType `hasInput`, from the
SystemImpactAnalysis to each AnalysisTrigger. A SystemImpactAnalysis is
expected to have many triggers, and each trigger may be associated with more
than one SystemImpactAnalysis.

Comment on lines +43 to +44
The /Core/rationale property describes the overall reason, scope, or conclusion
for the SystemImpactAnalysis. When a more detailed decision record is needed,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason, scope, and conclusion are different things. Should there be different properties for each?

Comment on lines +50 to +53
If a SystemImpactAnalysis uses the `duplicate` status, that status describes
the lifecycle state of the analysis itself. A separate decision record, when
used, can capture the agent or process decision that closed the analysis as a
duplicate and can link to the analysis that already covers the trigger or scope.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does duplicate warrant a special description here? What property would be marked duplicate? What other values can that property take on? Where are the descriptions for those other values?


## Summary

Describes a system impact analysis.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document appears to attempt to do two different things - assess the systemic impact of one or more triggers, and assess the systemic impact of added/removed/modified elements. The two are not the same. I recommend splitting this out into two separate documents:

  • SystemImpactAnalysis - Assess the impact of one or more triggers. This may or may not lead to systemic change.
  • SystemChangeImpactAnalysis - Assess the impact of one or more changes (add/removed/modified elements) to a system.

Comment on lines +73 to +84
- impactedElement
- type: /Core/Element
- minCount: 0
- addedElement
- type: /Core/Element
- minCount: 0
- modifiedElement
- type: /Core/Element
- minCount: 0
- removedElement
- type: /Core/Element
- minCount: 0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment at the top - I do not believe these belong in this document.

@devashridatta-dotcom devashridatta-dotcom changed the title [FuSa] Add AnalysisTrigger and SystemImpactAnalysis for system impact analysis [FuSa][FuSa] Separate trigger and system change impact analyses Nov 5, 2026
@devashridatta-dotcom devashridatta-dotcom changed the title [FuSa][FuSa] Separate trigger and system change impact analyses [FuSa] Separate trigger and system change impact analyses Nov 5, 2026

@chuckwolber chuckwolber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have lots more to add, but this should get us started. I will add additional elements found in DO-178C and @nicpappler will cover Automotive and other industries.

@@ -0,0 +1,65 @@
SPDX-License-Identifier: Community-Spec-1.0

# SystemChangeImpactAnalysis

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the name to SystemChangeAccomplishmentSummary.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From DO-178C, "The Software Accomplishment Summary is the primary data item for showing compliance with the Plan for Software Aspects of Certification (PSAC). This summary should include..."

  • System Overview
    • Description of the system's functions.
    • Allocation of functions to hardware and software.
    • The architecture.
    • Processors used.
    • Hardware/software interfaces.
    • Safety features.
  • Software Overview - Describes software functions with an emphasis on safety and partitioning (time/space) concepts used.
  • Certification Considerations - Restates certification considerations described in PSAC.
  • Software Life Cycle - (Additional details TBD) Summarize the actual software life cycle.
    • Software planning process.
    • Software development process - requirements, design, coding, and integration.
    • Software verification process, configuration management process, quality assurance process, certification liaison process.
  • Software Life Cycle Data
  • Additional Considerations - Additional considerations that may warrant the attention of the cert authority.
  • Supplier Oversight - If suppliers were used, describes how supplier processes and outputs comply with plans and standards.
  • Software Identification - Identifies software by part number and version.
  • Software Characteristics - Executable object code size, timing margins including worst-case execution time, memory margins, resource limitations, and the means used for measuring each characteristic.
  • Change History - Summary of software changes with attention to changes made due to failures affecting safety.
  • Software Status - Summary of problem reports unresolved at time of release. This is essentially "known issues". Includes:
    • Description of each problem.
    • Any associated errors.
    • Functional limitations.
    • Operational restrictions.
    • Potential adverse effects on safety.
    • Justifications for allowing the problem report to remain open.
    • Details of mitigating actions that have been, or need to be, carried out.
  • Compliance Statement - Statement of compliance to the SAS and a summary of methods used to demonstrate compliance with criteria specified in software plans. Addresses decisions made by cert authorities and deviations from software plans and standards.

All sections should also characterize areas that deviate from the system overview described in the PSAC.

@devashridatta-dotcom devashridatta-dotcom Nov 13, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuckwolber Just to clarify, I'll interpret this as renaming the existing SystemChangeImpactAnalysis class to SystemChangeAccomplishmentSummary and incorporating the DO-178C Software Accomplishment Summary concepts into its description, rather than introducing a separate class

@bact
bact self-requested a review November 7, 2026 09:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Profile:FuSa FunctionalSafety profile and related matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants