Repository navigation
Use exportControlClassificationResult in ExportControlClassificationAssessment - #1487
Merged
Merged
Conversation
…ssessment Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
umm0
approved these changes
Nov 16, 2026
Collaborator
Author
|
Discussed during 13 Nov 2026 Operations call and the meeting agreed with the proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Operations namespace, we have two properties with similar goal and data range:
/Operations/assessmentResult/Operations/exportControlClassificationResult(1) is used as a property for
/Operations/ExportControlClassificationAssessment(2) is orphaned. Never used in any class.
This PR proposes
ExportControlClassificationAssessmentto uses the specifically-named (2) instead, and reserves the generic nameassessmentResultfor future use.--
Currently, all other
assess*properties have generic ranges that can be use for any future non-export-control assessments:Having assessmentResult to specifically tied to ExportControlClassification range will limit our ability to reuse that property generically in the future.