Repository navigation
Release retained response buffers on discard in NettyWriteResponseFilter - #4349
Open
siddiqueirshad wants to merge 1 commit into
Open
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
spencergibb
requested changes
Oct 29, 2026
spencergibb
left a comment
Member
There was a problem hiding this comment.
Please add a test if possible
Author
|
Hi @spencergibb, added unit test |
…eResponseFilter Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
siddiqueirshad
force-pushed
the
fix/netty-write-response-filter-discard-leak
branch
from
October 29, 2026 17:37
312cac5 to
6eda0ec
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4332
Problem Description
In
NettyWriteResponseFilter, the response body stream is created with:receive().retain()increments the reference count of inbound NettyByteBufslices. When a client cancels or disconnects mid-response (e.g. mobile/browser connection drop),cleanup()only disposes the connection. Elements in flight betweenretain()and the outbound response write—including buffers buffered or queued in Reactor operators—are not released, leading to direct memory leak (LEAK: ByteBuf.release() was not called before it's garbage-collected) and pinningPoolChunks.Solution
Add
doOnDiscardhandlers to ensure discarded buffers are released upon cancellation or error:doOnDiscard(ByteBuf.class, ReferenceCountUtil::safeRelease)immediately followingretain()to handle discarded rawByteBufinstances.doOnDiscard(DataBuffer.class, ...)followingmap(...)to safely release discarded wrappedDataBufferinstances (catchingThrowableto safely tolerate potential concurrent release withFluxReceive.cleanQueue).