Repository navigation
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
See spring-projectsgh-52285 Signed-off-by: Jan Mohr <jan.mohr.1@web.de>
Align the exception message used in the earlier optimization. See spring-projectsgh-52285
philwebb
force-pushed
the
nested-jar-inflater-read-all-bytes
branch
from
October 18, 2026 22:46
03d6631 to
d8bebfd
Compare
Member
|
Thanks @janwaleed09! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
readAllBytes()override from 059525f is only inJarEntryInputStream, but class entries are normally deflated and go throughJarEntryInflaterInputStream, which still uses the default implementation with a 16 KB buffer and a copy. I added the same override toZipInflaterInputStreamand made both read only the remaining bytes, since the current one throwsEOFExceptionafter a partial read. Allocation untilApplicationReadyEventgoes down from 651 MB to 442 MB for PetClinic and from 540 MB to 354 MB for a sample app, and startup time didn't change measurably.