Repository navigation
Conversation
taekop
force-pushed
the
fix/pct-loss-tied-best
branch
from
October 20, 2026 10:26
9fd5cf5 to
cf863db
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several configurations tie for the best loss,
which(summary_res$.loss == 0)returns more than one index and1:best_indexwarns ("numerical expression has 2 elements: only the first used"). The selected configuration is the same either way, but the warning leaks to users. Usingmax()covers every tied-best row explicitly and removes the warning. The new test builds a tie and snapshots that no warning is raised.closes #1195