Repository navigation
Skip cache() when there is no dvc repo - #908
Open
raimbekovm wants to merge 3 commits into
Open
raimbekovm wants to merge 3 commits into
raimbekovm wants to merge 3 commits into
Conversation
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Live.cache()dereferencedself._dvc_repowithout checking it, butget_dvc_repo()returnsNoneoutside a git repo.Live(cache_images=True)+log_image()+end()in a plain directory (colab, kaggle, any non-git cwd) raisedAttributeError: 'NoneType' object has no attribute 'add'fromend(), whichcatch_and_warn(DvcException)does not catch.cache()now warns and returns when there is no dvc repo, the same waylog_artifact()already does. integrations that passcache_images=Trueno longer fail at the end of training outside git.measured
Live(cache_images=True)+log_image()+end()AttributeErrorfromend()images.dvcdvc init(test_cache_images[True])images.dvcwrittenfull suite: 255 passed; the 2
test_huggingface_log_model[DVCLiveCallback1-*-True]failures (Trainer.__init__() got an unexpected keyword argument 'tokenizer') also fail onmain.