Repository navigation
feat: implement caching for Environments and Schedules pages using React Query #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
48838e1
feat: integrate react-query for caching and api calls
harshil-2096 a47c818
Merge branch 'main' of github.com:truefoundry/trueforge into chore/hv…
harshil-2096 2a23531
test: update DraftCompositeSelector test to wait for capabilities bef…
harshil-2096 5e01952
Merge branch 'main' into chore/hv/react-query-server-client
harshil-2096 e4ecb1a
Merge branch 'main' into chore/hv/react-query-server-client
harshil-2096 8fc48be
Merge branch 'main' into chore/hv/react-query-server-client
harshil-2096 eea0cf9
chore: update dependencies to latest versions in pnpm-lock.yaml and p…
harshil-2096 bb5b530
Merge branch 'main' into chore/hv/react-query-server-client
harshil-2096 8700188
feat: implement caching for Environments and Schedules pages using Re…
harshil-2096 91e911e
refactor: replace state management with React Query for resource perm…
harshil-2096 e36d4b7
Merge remote-tracking branch 'origin' into chore/hv/react-query-envs-…
harshil-2096 390f177
fix(trueforge-ui): refresh environments via query invalidation after …
harshil-2096 e67db09
fix(trueforge-ui): guard placeholder pagination and pinned schedule rows
harshil-2096 cc97e08
Merge branch 'main' into chore/hv/react-query-envs-schedul-page
harshil-2096 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@truefoundry/trueforge-ui": patch | ||
| --- | ||
|
|
||
| Cache Environments and Schedules page reads on the shared server React Query client, and invalidate those queries after create, update, and delete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale environment pages after updates
Low Severity
Closing settings only
refetches the active environments list query, and pending-build polling onlysetQueryDatas that same key. Other cachedenvironments.listentries (different page size or token) stay fresh forstaleTimeand can still show old rows orpendingstatus. Create, update, and delete already invalidatequeryKeys.environments.all().Additional Locations (1)
packages/trueforge-ui/src/atoms/environments/EnvironmentsPage.tsx#L239-L253Reviewed by Cursor Bugbot for commit cc97e08. Configure here.