Skip to content

chore: allow right-click opening of sidebar links and table entries - #1412

Open
harshil-2096 wants to merge 8 commits into
mainfrom
chore/hv/allow-right-click-for-sidebar-and-table-items
Open

harshil-2096 wants to merge 8 commits into
mainfrom
chore/hv/allow-right-click-for-sidebar-and-table-items

Conversation

@harshil-2096

@harshil-2096 harshil-2096 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes AGE-2768

Changes

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, python/trueforge_sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Medium Risk
Broad changes to core shell navigation and URL/share state across many surfaces; behavior is covered by new and updated tests but regressions in in-app vs new-tab navigation are possible.

Overview
Adds ShellLink, a control that renders a real href for right-click / Cmd-click / middle-click while plain left-clicks still call existing shell onNavigate handlers (no full page reload).

Sidebar and rail targets (Agents, Sessions, Schedules, Environments, Settings, new chat/agent) and several table/list affordances now use it: agent library names and Try, thread/session rows, schedule names, and schedule run session chips.

Routing helpers buildPlaceHref, buildAgentSessionShareHref, sessionsBrowserOpenSearch, and openScheduleByIdSearch produce share-aware relative URLs. New-tab links retain host query params (e.g. theme) and pin the right schedule/session state; embedded agent-details schedules also keep scheduleId in sanitized search.

Reviewed by Cursor Bugbot for commit 1bf2604. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 76a5b69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@veria-ai

veria-ai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

PR overview

No security issues were found in this pull request.

Reviews

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

…-for-sidebar-and-table-items

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	packages/trueforge-ui/src/atoms/AgentsLibraryButton.tsx
#	packages/trueforge-ui/src/atoms/EnvironmentsButton.tsx
#	packages/trueforge-ui/src/atoms/SchedulesButton.tsx
#	packages/trueforge-ui/src/atoms/SessionsBrowserButton.tsx
#	packages/trueforge-ui/src/atoms/ShellActions.tsx
#	packages/trueforge-ui/src/atoms/ThreadListRow.tsx
#	packages/trueforge-ui/src/containers/ThreadListContainer.tsx
#	packages/trueforge-ui/src/layouts/SidebarLayout.tsx
#	packages/trueforge-ui/src/utils/sessionShareUrl.ts
@datadog-official

datadog-official Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Code Quality  Code Vulnerabilities  IaC  Library Vulnerabilities  Secrets

⚠️ Warnings

🛠️ 2 Code quality issues detected

Low: typescript-best-practices/boolean-prop-naming Consistent naming for boolean props View rule
packages/trueforge-ui/src/atoms/primitives/ShellLink.tsx:13
Low: typescript-best-practices/boolean-prop-naming Consistent naming for boolean props View rule
packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx:76

ℹ️ Info

No other issues found (see more)

🛡️ No new code vulnerabilities
📚 No new vulnerable libraries detected
🧱 No new Infrastructure as Code (IaC) issues
🔑 No new secrets detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1bf2604 | Docs | Give us feedback!

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

harshil-2096 and others added 2 commits November 20, 2026 15:42
…-for-sidebar-and-table-items

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx
Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1bf2604. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant