Repository navigation
[AGE-2841] Persist each thread's model and restore it for subagents #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hary73
wants to merge
10
commits into
main
Choose a base branch
from
haryahuja/age-2841-fix-subagent-model-overrides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f3fe824
refactor: split the model out of AgentDefinition into AgentModel
hary73 08c35d3
Merge branch 'main' into haryahuja/age-2841-fix-subagent-model-overrides
hary73 fd7906f
Fix subagent model overrides: own default params, record and restore …
hary73 a858bd3
chore: combine the AGE-2841 changesets
hary73 c2b4403
Address review: record each thread's model when it's created
hary73 a6560ec
Merge branch 'main' into haryahuja/age-2841-fix-subagent-model-overrides
hary73 3bc5b66
Record the main thread's model on every turn
hary73 009704c
Persist each thread's model and restore subagents on it
hary73 4fe5e33
Merge branch 'main' into haryahuja/age-2841-fix-subagent-model-overrides
hary73 dc6043f
Rename ThreadModel to ModelSnapshot
hary73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@truefoundry/trueforge-core': patch | ||
| '@truefoundry/trueforge': patch | ||
| --- | ||
|
|
||
| Persist the model each thread runs on, so a rebuilt subagent resumes on it. A subagent on a different model from its parent runs on that model's own defaults instead of the parent's params. `AgentDefinition` no longer carries the model; it's a separate `AgentModel`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 1 addition & 15 deletions
16
packages/trueforge-core/src/core/runtime/AgentDefinition.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import type { ILLM } from '../llm/ILLM'; | ||
| import type { ModelParams } from '../llm/model'; | ||
| import type { VercelAIProviderName } from '../llm/VercelAILLM'; | ||
|
|
||
| /** The model a thread runs on, resolved for that thread. */ | ||
| export interface AgentModel { | ||
| client: ILLM; | ||
| /** `provider/model`. */ | ||
| name: string; | ||
| /** Configured provider. Omitted when the host did not resolve one. */ | ||
| providerType?: VercelAIProviderName | undefined; | ||
| properties?: | ||
| | { | ||
| /** Maximum combined input/output context for the resolved model, when known. */ | ||
| contextLength: number | undefined; | ||
| } | ||
| | undefined; | ||
| params?: ModelParams | undefined; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.