Repository navigation
[Hotfix] Cherry-pick to release-v0.179.6 - #1449
Open
truefoundry-saas wants to merge 3 commits into
Open
truefoundry-saas wants to merge 3 commits into
truefoundry-saas wants to merge 3 commits into
Conversation
rutvij-menavlikar
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
thesujai
as code owners
November 20, 2026 10:32
chiragjn
reviewed
Nov 20, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cherry-pick for release request
44a73633-803b-4bf5-89b4-5bc3fc59e4fa.Source PRs (merged to main):
Also landing with this hotfix:
withServerOverrideHeadersutil #1430These two are already on
release-v0.179.6, manually cherry-picked by #1447.Warning
This PR does not contain the fix yet. The cherry-pick conflicted, so
automation stopped at the first conflicting commit and left the rest out.
GitHub therefore shows this PR as mergeable, with no conflict to resolve —
it currently carries no changes at all (an empty placeholder commit).
Paste the prompt below into any coding agent that has this repository open.
It checks out this branch, applies the missing commits, and pushes.
Do not merge the PR. The release request checks every commit within a few
minutes (or use "Sync status" on it). The PR is merged when the request is
approved — or, if it is already approved, when a QA member or engineering
admin uses "Retry merge".
Agent prompt — copy from here:
Conflicting file(s):
.github/fern/openapi/openapi.jsondocs/openapi.jsonpackages/trueforge/tests/unit/truefoundry/TrueFoundryMcpServerStore.test.tspython/trueforge_sdk/reference.mdCommits still to apply (starting at the conflict):
584a376708b64b7738e3c925c533793dd628cda6Do not merge manually — this PR is merged automatically when the release request is approved. If you do merge it yourself, use "Sync status" on the request so it stops showing as pending.
Note
Low Risk
Targeted OAuth redirect behavior and input validation on an optional query param, with tests and no broad auth refactors.
Overview
MCP authorize
return_tois now truly optional. OnGET /api/v1/mcp-servers/{name}/authorize, whenreturn_tois not provided the TrueFoundry MCP gateway call omitsredirectURL, so users see the gateway’s default post-auth page instead of being redirected into TrueForge.Stricter query validation: an explicit empty
return_tois rejected (400) viaminLength: 1on the route schema and handler checks that run when the parameter is present (returnTo !== undefined). OpenAPI, Fern SDK types, and Python SDK docs are aligned with “omit = no redirect.”Upstream behavior:
TrueFoundryMcpServerStore.authorizeonly resolves and passesredirectURLwhenreturnTois set; tenant control-plane URL lookup is skipped when no redirect is requested. Unit tests cover emptyreturn_toand the no-redirectURLpath.Reviewed by Cursor Bugbot for commit 58d4f37. Bugbot is set up for automated code reviews on this repo. Configure here.