Repository navigation
fix: block path traversal in disk and http file proxies - #178
Open
darzasassing-hub wants to merge 1 commit into
Open
darzasassing-hub wants to merge 1 commit into
darzasassing-hub wants to merge 1 commit into
Conversation
Reject '..' path segments in resolveFileProxy with 400 and enforce containment within diskPath root in resolveDiskProxy with 403. Add tests verifying path traversal prevention. Fixes tscircuit#173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #173 — Path traversal in disk and http file proxies allowed reading files outside the proxy root via
..segments.Changes
resolveFileProxy, check if any segment ofrelativePathis..and return400 Bad Request(Invalid path: path traversal not allowed). This immediately blocks traversal on both disk and http proxies.resolveDiskProxy, useresolve()to compute the target path and verify it stays strictly contained within the resolved root ofdiskPath, returning403 Forbiddenif escaped.tests/routes/path-traversal-proxy.test.tstesting unit-level rejection on disk and http proxies as well as route-level query parameter verification.Verification
bun test: All tests pass (including existing file-proxy suites and new path traversal tests)./claim #173
/attempt #173