Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
=======================================
Coverage 88.07% 88.08%
=======================================
Files 43 43
Lines 3891 3893 +2
Branches 993 994 +1
=======================================
+ Hits 3427 3429 +2
Misses 264 264
Partials 200 200 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting an all-zero NANPA number for a call from another NANPA region now preserves its retained raw input, matching Java and the existing netstandard2.0 implementation. The modern span shortcut previously bypassed
Format(NATIONAL)'s raw-input fallback, reformatted the zeros, and could append an extension that the fallback omits.For example, parse
000-000-0000withParseAndKeepRawInput(..., "US"), then callFormatOutOfCountryCallingNumber(number, "US"): the old modern implementation returned1 000 000 0000; Java and this fix return1 000-000-0000.Severity: P3, high confidence. This affects all-zero/invalid numbers accepted by parsing or constructed with the builder. The fix adds the missing fallback to the NANPA span shortcut and retains the current normal-number path. No public API, metadata, regex, dependency, or Java source changes.
Java parity evidence:
33be5664343676b27761213d8f5500d682568ea7.formatOutOfCountryCallingNumbercallsformat(number, NATIONAL)for NANPA calls;formatpreserves raw input for zero national numbers. The existing upstreamtestFormatUSNumbercovers this fallback.setCountryCode(0)is present in Java,HasCountryCodeis false in C#); deferred under the one-fix limit. This is not a whole-library parity claim.14fdad223881d77c7679cbf6e6e0eecc52e036f5, through the original builders. No metadata contents were manually inspected or edited.Validation:
C# review baseline:
2a0bb649a22a518ee74133fdbcebcf39f8ebbbd4. Both baseline histories were unchanged since the preceding successful review; open upstream PRs were checked for duplicates.