Repository navigation
Conversation
…ched fields. The regex-delete-match and regex-replace-match operators checked whether the matched data key was present in the extracted row. The extracted row is keyed by the rule's field, which for a regex field is the pattern itself, so these rules were silently skipped whenever "regex field" was enabled. Check rule.field instead. Add tests for the extraction engine, including a chat-message redaction case. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TuYaXTVENZeff6o2Eb3Jfz
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The regex-delete-match and regex-replace-match operators checked whether the matched data key was present in the extracted row. The extracted row is keyed by the rule's field, which for a regex field is the pattern itself, so these rules were silently skipped whenever "regex field" was enabled. For example, if the "^test:chat:.*" is used to match field "test:chat:792179ee83d1" in the extraction, the regex-delete-match and regex-replace-match cannot be used for deleting/replacing string in matched output, without specify the actual name of the field.
Fix
extractionEngine.ts is updated to use rule.field instead for handling regex matched field. Also add tests for the extraction engine, including a chat-message redaction case.