Repository navigation
test: add base styles visual tests for pdf-viewer - #13283
Draft
web-padawan wants to merge 8 commits into
Draft
web-padawan wants to merge 8 commits into
web-padawan wants to merge 8 commits into
Conversation
web-padawan
changed the title
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
2 times, most recently
from
October 27, 2026 09:59
94745ce to
a50aa4c
Compare
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
3 times, most recently
from
October 27, 2026 10:22
684719f to
876b6d7
Compare
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
from
October 27, 2026 10:22
a50aa4c to
4a5cb47
Compare
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
from
October 27, 2026 11:41
876b6d7 to
18c4b35
Compare
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
from
October 27, 2026 11:42
4a5cb47 to
8e2bcb1
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
from
October 27, 2026 11:46
18c4b35 to
9d6038f
Compare
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
from
October 27, 2026 11:46
8e2bcb1 to
47ddacd
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
from
October 27, 2026 12:22
47ddacd to
66ed419
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
from
October 27, 2026 12:44
66ed419 to
934872b
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pdf-viewer has no Lumo and Aura styles yet, so the Lumo and Aura visual configs skip it until a later PR adds them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
web-padawan
force-pushed
the
test/pdf-viewer-visual-tests
branch
from
October 27, 2026 13:12
c375fa0 to
ea7b9ef
Compare
|
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
from
October 28, 2026 06:51
b206737 to
64f0a51
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #7669
Depends on #13281
vaadin-pdf-viewerwith 10 screenshotsdocument,actions(600px),actions-wide(900px),narrowandnarrow-rtl(240px) with a slottedvaadin-buttonempty,page-error,large-textwith a scrolling headercontent-focuswith the square top corners of the ring,button-focuswith the button tooltipcreatePdf()pdf-viewerfrom the Lumo and Aura visual configs inwtr-utils.jstest/visual/basefolder but nolumoandaurafilesThe screenshots cover the layout checks that #13281 dropped from the unit tests: where the toolbar groups go at each width.
Type of change
Different from prototype
🤖 Generated with Claude Code