Repository navigation
Attach files with first upload attempt in vision mode - #3317
Merged
Merged
Conversation
A click_at on an upload control is stopped by the file-chooser guard, and the upload handoff tells the model to call upload_file with the selector in that click's result. The page-action binding check refused that first call (target_uncovered, recovery get_interactive_elements) whenever the step's page capture had not certified the input, as on a long GitHub release form whose hidden file input lies past the capture's scan budget. The model then listed the page's file inputs and sent the same call again: two wasted steps per file. The blocked click's result is how the model observed the input, so the handoff now records it. The handoff keeps the selectors its blocked choosers named (not on the compact tier, whose upload_file finds its own target). When the handoff starts, before the step's page capture, _pageFeedbackObserveUploadTargets sends the new page_monitor_record_upload_targets message: the page monitor keeps the node each selector names now under a fresh inventory token, and the run's upload scope holds exactly those selectors (source upload_handoff). The capture then certifies the input when it can; otherwise validation reports it as inventoried and the first upload_file is sent with an advisory note that names the blocked click. Not weakened: a guessed selector, even one naming the same input, a node the page renders later under the same selector, and an answer from another document are refused as before. With Strict checks on, the call is refused as an inventoried input's is, unless the capture certified the input. page-feedback-target-binding now declares its mustNotBlock test. Tests cover both builds: the handoff's record and scope, guessed and re-mounted inputs, Strict checks, a batch with several choosers, the compact tier, both run loops, the real page monitor in Chromium and Firefox, and a Chrome MV3 run on a deep release page whose first upload_file was refused before this change and attaches now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Vision mode: attach each file with the first upload attempt
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.