Skip to content

Use SunLimitedUnsafeReflectionProvider not SunUnsafeReflectionProvider on 23+ #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jglick wants to merge 1 commit into
base: v-1.4.x
Choose a base branch
from
Open

Use SunLimitedUnsafeReflectionProvider not SunUnsafeReflectionProvider on 23+ #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion xstream/src/java/com/thoughtworks/xstream/core/JVM.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ static class Test {
canAllocateWithUnsafe = test;
test = false;
Class type = PureJavaReflectionProvider.class;
if (canUseSunUnsafeReflectionProvider()) {
if (isVersion(23) && canUseSunUnsafeReflectionProvider()) {

@lizlooney lizlooney Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean canUseSunLimitedUnsafeReflectionProvider here?

@jglick jglick Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This is capturing the value of

xstream/xstream/src/java/com/thoughtworks/xstream/core/JVM.java

Line 90 in 264df8b

canAllocateWithUnsafe = test;
whereas

xstream/xstream/src/java/com/thoughtworks/xstream/core/JVM.java

Line 127 in 264df8b

canWriteWithUnsafe = test;
is not available yet. The original code was perhaps confusingly written. All I am changing here is what the PR title says.

@lizlooney lizlooney Aug 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, I see. Thanks for the clarification.

type = loadClassForName("com.thoughtworks.xstream.converters.reflection.SunLimitedUnsafeReflectionProvider");
} else if (canUseSunUnsafeReflectionProvider()) {
Class cls = loadClassForName("com.thoughtworks.xstream.converters.reflection.SunUnsafeReflectionProvider");
if (cls != null) {
try {
Expand Down
Loading