Repository navigation
tools/oxenstored: Reset quota when resetting permissions - #28
Merged
Merged
Conversation
The quota object contains both limits and the current node usage counts. When a domain is torn down, the node data itself is cleaned up but the node usage counts are not. A later domain reusing the same domid can create fewer nodes before being deemed to be over quota. Reset the count when the node permissions are cleaned up. This is XSA-483 / CVE-2026-23556. Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Contributor
Author
|
I've used the patch posted as part of the XSA here: https://xenbits.xen.org/xsa/xsa483-xapi.patch |
psafont
approved these changes
Apr 28, 2026
lindig
approved these changes
Apr 30, 2026
Contributor
That's a rare case because a domid would need to warp around? If and how that happens is outside the control of this code, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quota object contains both limits and the current node usage counts.
When a domain is torn down, the node data itself is cleaned up but the node usage counts are not. A later domain reusing the same domid can create fewer nodes before being deemed to be over quota.
Reset the count when the node permissions are cleaned up.
This is XSA-483 / CVE-2026-23556.