Repository navigation
Backport a fix re-trying xapi connection - #20
Merged
Merged
Conversation
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Contributor
Author
|
Scratch build: https://koji.xcp-ng.org/taskinfo?taskID=110781 |
gduperrey
approved these changes
Aug 5, 2026
Contributor
We should probably create a card to track it, once the have the basics from current work it should be easier to add new tests, and we already know how to test it. |
Contributor
Author
Done, it's XCPNG-3619 |
rzr
approved these changes
Aug 6, 2026
Contributor
Author
|
Build in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main information
Work Item Reference
XCPNG-3618
Context & Motivation
If xsconsole fails to connect to xapi once, it never tries again (most often happens during HA master failover). On a long-running xsconsole instance (on the physical console, for example) it is especially important to reflect the correct state of the pool. This fix re-tries the connection after a cooldown wait.
Release Target
8.3-next+1Release Notes and Documentation
Explain the change to users
Attention points
None
Documentation update needed
Testing and regression avoidance
What tests have you performed?
Manual testing by Olivier and forum users
What manual tests should be performed after the build, and by whom?
The upstream PR describes the procedure for killing xapi and checking xsconsole re-tries the connection: xapi-project/xsconsole#90
What's covered by the xcp-ng-tests test suite?
xsconsole is not currently covered, but it is planned to be.
What tests have been or will be added to CI for this change? If none, explain why.
None
Xen Orchestra Impact
Does this affect existing features in Xen Orchestra, or add new features that could be useful?